This merges in the upstream commits from maslow into the release/holey branch. I had to fix a few conflicts.
I am unclear where I should be pushing this too. If this is the wrong repository or branch let me know, I can easily rebase off of the correct branch.
It seems like this is a necessary step before merging the holey calibration back upstream into maslow.
Does this firmware change affect kinematics or any part of the calibration process?
No
d) Has this PR been tested on actual machine and/or in fake servo mode (indicate which or both)?
Only in fake servo mode.
It has been a while since I have done this, someone should probably confirm that I didn't break anything.
How can this pull request be tested?
The B17-19 commands. Fake Servo testing with B99. The G2 command. I didn't edit anything, so if it works upstream it should work here as long as my conflict resolution isn't awful.
What does this pull request do?
This merges in the upstream commits from maslow into the release/holey branch. I had to fix a few conflicts.
I am unclear where I should be pushing this too. If this is the wrong repository or branch let me know, I can easily rebase off of the correct branch.
It seems like this is a necessary step before merging the holey calibration back upstream into maslow.
Does this firmware change affect kinematics or any part of the calibration process?
No
d) Has this PR been tested on actual machine and/or in fake servo mode (indicate which or both)?
Only in fake servo mode.
It has been a while since I have done this, someone should probably confirm that I didn't break anything.
How can this pull request be tested?
The B17-19 commands. Fake Servo testing with B99. The G2 command. I didn't edit anything, so if it works upstream it should work here as long as my conflict resolution isn't awful.