search

WebCrateApp / webcrate

📦🔗 Organize your web with WebCrate, a modern and beautiful bookmarking tool
https://webcrate.app
MIT License
734 stars 55 forks source link

✨ Add the Web Share Target API #46

Closed hkamran80 closed 2 years ago

hkamran80 commented 2 years ago

This PR adds the Web Share Target API to WebCrate.

Discussed in #29 (comment) and #44.

BetaHuhn commented 2 years ago

Why the change to the copy-templates script?

hkamran80 commented 2 years ago

I use macOS, and it wouldn't recognize the -r argument to cp.

While -R is posix well-defined, -r is not portable! On Linux, in the GNU and BusyBox implementations of cp, -r and -R are equivalent. On the other side, as you can read in the POSIX manual page of cp, -r behavior is implementation-defined.

Source: this Stack Exchange answer

BetaHuhn commented 2 years ago

Ah okay, makes sense. Didn't know that -r only works on Linux, thanks for the explanation and source!

Will merge this tomorrow and release it with a few other fixes later this or next week.

hkamran80 commented 2 years ago

No problem! Thank you!

WebCrateBot commented 2 years ago

:tada: This PR is included in version 1.4.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: