Closed leefrank9527 closed 4 months ago
@hannakoppelaar ready for you to review/merge
@leefrank9527 It looks good! There's just a minor thing I noticed with respect to the removal of the max rows limitation. The method searchUrlDTOs in NetworkMapClientLocal now has a boolean parameter to disable this limitation. However, in other methods (searchUrl, queryChildrenRecursivelyCrawl and queryChildrenRecursivelyFolder) the code dealing with this limitation is commented out. I think it would make the code easier to understand if we simply got rid of the limitation completely: removing the parameter allowBigDatasets from searchUrlDTOs and deleting the commented out sections.
searchUrlDTOs
@hannakoppelaar Thanks for the feedback. Accepted the advices and cleared the comments and redundant argument. I've commited the changes to this PR.
Fixed the issues and improved the performance for visualization:
Removed the max rows limitation from the grid view of visualization. Related to issue Remove the limitaion of the maximum number of rows from inspection view. #96
Improved the performance of UI: