search

WebCuratorTool / webcurator

The root of the webcurator tool project, containing all modules needed to run a fully functional webcurator tool.
Apache License 2.0
2 stars 1 forks source link

V3.0/add context path #15

Closed leefrank9527 closed 3 years ago

leefrank9527 commented 4 years ago
  1. Changed the URL combination mechanism of all client classes and configurations from H1/H3/Store/WebApp sides. To replace the separated configuration items of "scheme/host/port" to an URL, so the URL could be manually combined flexibly.
  2. Refined the resource file transferring method to support huge files.
obrienben commented 3 years ago

Reviewed and tested locally and in our UAT env, with and without setting a context of '/wct' in Webapp. Everything worked as expected.

hannakoppelaar commented 3 years ago

I'm getting this exception at index time:

Exception in thread "Thread-5" java.lang.IllegalArgumentException: [null/harvest-coordinator/finalise-index/{harvest-result-oid}] is not a valid HTTP URL at org.springframework.web.util.UriComponentsBuilder.fromHttpUrl(UriComponentsBuilder.java:290) at org.webcurator.core.store.IndexerBase.finaliseIndex(IndexerBase.java:93) at org.webcurator.core.store.IndexerBase.markComplete(IndexerBase.java:80) at org.webcurator.core.store.IndexerBase.run(IndexerBase.java:64) at java.lang.Thread.run(Thread.java:748)

The base URL of one of the Indexers is null, so it's probably not being propagated from the config. I'm not overriding that value in my application-local.properties, so it should be okay. Are you seeing this as well?

leefrank9527 commented 3 years ago

@hannakoppelaar There are some Index related classes aren't initialed correctly. I've fixed them and update to this branch: v3.0/add-context-path. Modification list:

hannakoppelaar commented 3 years ago

I did an end-to-end test including indexing and it looks good now.

obrienben commented 3 years ago

Thanks @hannakoppelaar @leefrank9527. I'll merge into master now