search

WebCuratorTool / webcurator

The root of the webcurator tool project, containing all modules needed to run a fully functional webcurator tool.
Apache License 2.0
2 stars 1 forks source link

Master 3.1 added the missing commits and removed the bandwidth related codes. #41

Closed leefrank9527 closed 3 years ago

leefrank9527 commented 3 years ago

Added the missing commits and removed the bandwidth related codes.

obrienben commented 3 years ago

Thanks @hannakoppelaar. @leefrank9527 perhaps if there's no strong reason to use Void, then we should switch back to String types to be on the safe side?

leefrank9527 commented 3 years ago

@hannakoppelaar @obrienben The Void.class is only used for the controllers which return a void value. The return value (void) will not be set to any variables in this case. So I think this is safe to use Void.class.

hannakoppelaar commented 3 years ago

@obrienben @leefrank9527 I do remember seeing runtime exceptions caused by the use of Void in RestTemplate, but I am unable to reproduce them, so I guess this has been fixed in Spring.

I think we can merge this.

leefrank9527 commented 3 years ago

@hannakoppelaar Yes. I think we can merge it. If there are issues happen we can resolve them case by case.