Closed leefrank9527 closed 4 months ago
@hannakoppelaar @obrienben I updated the screenshot feature with: 1) Migrated the screenshot tool of the java version into the Store component as a builtin screenshot tool. 2) Refactored some of the configuration items in application.properties of the Store component. 3) Added or changed the test cases related to the screenshot feature.
@leefrank9527 @obrienben
The pywb banner is visible in the archive screenshot. Shouldn't that be removed or is this how it's supposed to work?
Update @leefrank9527, @obrienben: I was using pywb version 2.6.7 when I tested this.
@hannakoppelaar @obrienben : I've integrated the screenshot with multiple *waybacks, and updated the v3.1.3/screenshot-merged branch. The changes are:
One point have to mention is the way to put WARC files into pywb. Different from the way for OpenWayBack, the command wb-manager
is used to deposit the WARC files to pywb. The way is recommended by pywb group, and the indexing is processed and loaded synchronously. It's different from that revealed in the document: https://webcuratortool.readthedocs.io/en/latest/guides/wayback-integration-guide.html
Maybe it's a good idea to add the necessary changes to https://webcuratortool.readthedocs.io/en/latest/guides/wayback-integration-guide.html#pywb-configuration and https://webcuratortool.readthedocs.io/en/latest/guides/system-administrator-guide.html#digital-asset-store-application-properties in this PR?
It looks okay, I did find a minor issue: even though the application manages to create screenshots, in the log file it complains that it has an "Unrecognised argument 'native'. Cannot generate screenshot." It seems that the switch statement in SeleniumScreenshotCapture.java is missing a 'native' case?
It looks okay, I did find a minor issue: even though the application manages to create screenshots, in the log file it complains that it has an "Unrecognised argument 'native'. Cannot generate screenshot." It seems that the switch statement in SeleniumScreenshotCapture.java is missing a 'native' case?
@hannakoppelaar @obrienben Has fixed the issue and update the docs related to screenshot.
Had rebased the screenshot to 3.1.3, and had an integrated testing with Pywb for the screenshot of havested contents.