search

WebDevStudios / Automatic-Featured-Images-from-Videos

If a YouTube or Vimeo video exists in the first few paragraphs of a post, automatically set the post's featured image to that vidoe's thumbnail.
33 stars 24 forks source link

feature/bulk-update: continue working on the jQuery involved with bulk edit process buttons #31

Closed tw2113 closed 6 years ago

tw2113 commented 7 years ago
  1. Move post type and i18n strings to wp_localize_script().
  2. Move output to an external js file.
binarygary commented 7 years ago

Both points are handled in the most recent commit https://github.com/WebDevStudios/Automatic-Featured-Images-from-Videos/tree/feature/bulk-update

tw2113 commented 7 years ago

Looking good overall. I can't find any lingering issues that need immediately addressed, other than perhaps some QA.

binarygary commented 7 years ago

QA would be great. I've been testing as I go, but extra eyes in different environments would be great.