search

WebDevStudios / Automatic-Featured-Images-from-Videos

If a YouTube or Vimeo video exists in the first few paragraphs of a post, automatically set the post's featured image to that vidoe's thumbnail.
33 stars 24 forks source link

feature/display_video_metabox_post_edit: metabox content #33

Closed tw2113 closed 7 years ago

tw2113 commented 7 years ago

Not sure how I feel about re-embedding the video again. It's already going to be embedded in the visual editor, fully playable.

Perhaps instead of an iframe, we simply list the video URL that was found.

binarygary commented 7 years ago

I'm fine with this. I see the logic in both.

Addressed in https://github.com/WebDevStudios/Automatic-Featured-Images-from-Videos/pull/34 despite the branch name, it now displays the URL and embed URL in the meta box.

tw2113 commented 7 years ago

Closing as merged into master.