Use of get_the_ID() when $post_id is passed in

[tw2113]

Nitpicky extra function call but we do get the specific post ID passed into the callback that we can use instead of get_the_ID().

[bradp]

We changed this in 3a7ff90f711a891640dca38541821a28c7a69fb8, as we found it to be more consistent, because otherwise we seemed to get revision IDs or something sometime.

Brad Parbs

On Jan 29, 2015, at 7:34 PM, Michael Beckwith notifications@github.com wrote:

Nitpicky extra function call but we do get the specific post ID passed into the callback that we can use instead of get_the_ID().

— Reply to this email directly or view it on GitHub.

[tw2113]

Ah.

if ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ) {
    return;
}

should solve that issue, for future consideration. The save_posttype hook would have those two firing regularly.

[bradp]

PR it up!

Brad Parbs

On Jan 29, 2015, at 7:46 PM, Michael Beckwith notifications@github.com wrote:

Ah.

if ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ) { return; } should solve that issue, for future consideration. The save_posttype hook would have those two firing regularly.

— Reply to this email directly or view it on GitHub.

[jtsternberg]

:+1:

[tw2113]

This got fixed at some point.