WebDevStudios / BuddyPress-Registration-Options

Moderate new BuddyPress members, fight BuddyPress spam, set BuddyPress Groups or Blogs/Sites new members can join on the registration page.
28 stars 16 forks source link

Buddy Press registration email error #182

Closed Klau54 closed 4 years ago

Klau54 commented 4 years ago

So I was testing out the Buddy press registration plugin that works with Buddy forms. When I tested out the dummy accounts , As an admin I could see in the member request who is requesting to become a subscriber to the website. When I clicked approve, there should have been an email sent to the dummy account's email address. Problem is that there is no email of approval showing up on the dummy account's email inbox. What could be causing this issue?

tw2113 commented 4 years ago

What "Buddy forms" are you referring to, in case it's playing a part in things?

Klau54 commented 4 years ago

By “buddy form” I mean the plugin called Buddy forms created by theme craft. To be more exact I have three “Buddy” Plugins working together. There is Buddy Press Registrations, Buddy Press members only, and then there’s Buddy Forms. I’m more concerned with Buddy Press registration since it is the plugin responsible for sending and email of approval to users who want to become members. From: Michael Beckwith notifications@github.com Sent: Tuesday, February 18, 2020 11:58 AM To: WebDevStudios/BuddyPress-Registration-Options BuddyPress-Registration-Options@noreply.github.com Cc: Josh Arevalo jarevalo@aipumps.com; Author author@noreply.github.com Subject: Re: [WebDevStudios/BuddyPress-Registration-Options] Buddy Press registration email error (#182)

What "Buddy forms" are you referring to, in case it's playing a part in things?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/WebDevStudios/BuddyPress-Registration-Options/issues/182?email_source=notifications&email_token=AOS6YOZOGYRBNBHJBFB2XFTRDQVUFA5CNFSM4KXKIHAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMDQAIA#issuecomment-587661344, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOS6YO76I6ITTFUY2R76OQ3RDQVUFANCNFSM4KXKIHAA.

Klau54 commented 4 years ago

Buddy Press as a whole is working properly when it comes to emails, even the test emails written in Latin won't show up in my inbox. The major concern for me is that activation emails are being sent to users who are approved.

tw2113 commented 4 years ago

Out of curiosity, has anyone checked spam filters just in case?

Beyond that, we don't do anything special outside of passing things through wp_mail() and some filters to get html support for the emails so it's a bit hard for me to point to anything specific and go "it's in this area!"

Klau54 commented 4 years ago

Yeah, I’ve check the dummy account’s spam folder and there is nothing there.

From: Michael Beckwith notifications@github.com Sent: Tuesday, February 18, 2020 8:39 PM To: WebDevStudios/BuddyPress-Registration-Options BuddyPress-Registration-Options@noreply.github.com Cc: Josh Arevalo jarevalo@aipumps.com; Author author@noreply.github.com Subject: Re: [WebDevStudios/BuddyPress-Registration-Options] Buddy Press registration email error (#182)

Out of curiosity, has anyone checked spam filters just in case?

Beyond that, we don't do anything special outside of passing things through wp_mail() and some filters to get html support for the emails so it's a bit hard for me to point to anything specific and go "it's in this area!"

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/WebDevStudios/BuddyPress-Registration-Options/issues/182?email_source=notifications&email_token=AOS6YO5HVPYLIJ7WCEAHSALRDSSVRA5CNFSM4KXKIHAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMGHOIQ#issuecomment-588019490, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOS6YO2CQMTOPWKFKRD7HHTRDSSVRANCNFSM4KXKIHAA.

Klau54 commented 4 years ago

I've tried using SMTP but even then the email approving the user is not going to the inbox or my junk email. What should I do from here?

tw2113 commented 4 years ago

Dunno what to tell you without having much more elevated access to the install to see where it's possibly failing for sure.

I'm looking at our code, specifically inc/admin.php and the bp_registration_options_form_actions() function where we process approval/denial.

The only spots I see that would probably stop things would be the check_admin_referer( 'bp_reg_options_check' ); result, and then if the $send variable never gets set to true, which it should if "deny" or "approve" are the performed actions. Those values would come from a $_POST['moderate'] being set. Below are some links to the specific spots in the code where we handle these parts mentioned.

Function declaration: https://github.com/WebDevStudios/BuddyPress-Registration-Options/blob/master/includes/admin.php#L160

Moderate $_POST value checks: https://github.com/WebDevStudios/BuddyPress-Registration-Options/blob/master/includes/admin.php#L193-L221

Section where we check if we should send anything, for a given approved user: https://github.com/WebDevStudios/BuddyPress-Registration-Options/blob/master/includes/admin.php#L289-L315

I wonder if a plugin like https://wordpress.org/plugins/email-log/ could help deduce what's going on and why.

Klau54 commented 4 years ago

I resolved the issue everything is running smoothly again thank you for time.

From: Michael Beckwith notifications@github.com Sent: Thursday, February 20, 2020 10:19 PM To: WebDevStudios/BuddyPress-Registration-Options BuddyPress-Registration-Options@noreply.github.com Cc: Josh Arevalo jarevalo@aipumps.com; Author author@noreply.github.com Subject: Re: [WebDevStudios/BuddyPress-Registration-Options] Buddy Press registration email error (#182)

Dunno what to tell you without having much more elevated access to the install to see where it's possibly failing for sure.

I'm looking at our code, specifically inc/admin.php and the bp_registration_options_form_actions() function where we process approval/denial.

The only spots I see that would probably stop things would be the check_admin_referer( 'bp_reg_options_check' ); result, and then if the $send variable never gets set to true, which it should if "deny" or "approve" are the performed actions. Those values would come from a $_POST['moderate'] being set. Below are some links to the specific spots in the code where we handle these parts mentioned.

Function declaration: https://github.com/WebDevStudios/BuddyPress-Registration-Options/blob/master/includes/admin.php#L160

Moderate $_POST value checks: https://github.com/WebDevStudios/BuddyPress-Registration-Options/blob/master/includes/admin.php#L193-L221

Section where we check if we should send anything, for a given approved user: https://github.com/WebDevStudios/BuddyPress-Registration-Options/blob/master/includes/admin.php#L289-L315

I wonder if a plugin like https://wordpress.org/plugins/email-log/ could help deduce what's going on and why.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/WebDevStudios/BuddyPress-Registration-Options/issues/182?email_source=notifications&email_token=AOS6YO52FYKBHGDAIKMBAZTRD5P25A5CNFSM4KXKIHAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMRRSRY#issuecomment-589502791, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOS6YO7PUIOAXIRBKJ3NZADRD5P25ANCNFSM4KXKIHAA.

tw2113 commented 4 years ago

What was the issue, out of curiosity in case someone else comes in with the same issue?

Klau54 commented 4 years ago

So for background information, I have a friend who was working on an app which works along side with some of the plugins. He did some work on a tools app for the site. Whatever he did he resolved the Buddy Forms issue along with a couple of other ones. I can’t give you an exact detail. Bur from what he said it had something to do with cookie parsing.

From: Michael Beckwith notifications@github.com Sent: Tuesday, February 25, 2020 2:10 PM To: WebDevStudios/BuddyPress-Registration-Options BuddyPress-Registration-Options@noreply.github.com Cc: Josh Arevalo jarevalo@aipumps.com; Author author@noreply.github.com Subject: Re: [WebDevStudios/BuddyPress-Registration-Options] Buddy Press registration email error (#182)

What was the issue, out of curiosity in case someone else comes in with the same issue?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/WebDevStudios/BuddyPress-Registration-Options/issues/182?email_source=notifications&email_token=AOS6YO5UAX6GPJCSRETYS2LREWCKBA5CNFSM4KXKIHAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM5QKKA#issuecomment-591070504, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOS6YO4WTHRS4WOI3TC6523REWCKBANCNFSM4KXKIHAA.

tw2113 commented 4 years ago

Gotcha. Thanks for providing what you could :)

Glad to hear things are working again.