Able to send a connection request to unapproved members

WebDevStudios / BuddyPress-Registration-Options

Moderate new BuddyPress members, fight BuddyPress spam, set BuddyPress Groups or Blogs/Sites new members can join on the registration page.

28 stars 16 forks source link

Able to send a connection request to unapproved members #204

Open hellodanevans opened 2 years ago

hellodanevans commented 2 years ago

We were able to send a connection request to unapproved members via this button on the BuddyBoss member search:

Unless we've misunderstood, making connection requests to unapproved members shouldn't be possible?

Thanks

tw2113 commented 2 years ago

Admittedly not a 1 setting that takes out EVERYTHING, we have to find each individual part and determine how to best remove the UI for each instance, so this is likely an edgecase that just hadn't been found/handled yet.

That said, if this is also something exclusive to BuddyBoss, then it's definitely not a handled thing, because we haven't actively tried to make things work with that forked plugin still.

For example, out of box BuddyPress isn't showing that "user+" icon, at least not for my local at the moment.

hellodanevans commented 2 years ago

Hi there, thanks for the quick reply. Ah so it doesn't disable the functionality but instead hides the UI like buttons that allow it. No problem, understood.

tw2113 commented 2 years ago

If there's a way to globally disable some capabilities, then that's a worthy thing to investigate, otherwise, I'll see what I can do here. I already saw some ready changes that got missed with 4.10.0, so there's room to get in a different release

hellodanevans commented 2 years ago

I've reached out to buddyboss to see if this is possible.

On a different point but similar issue... when using your plugin on buddypress, are non-approved users hidden from the member search? As currently they are still visible in the member search with buddyboss.

Maybe it's fair to say your plugin isn't really for buddyboss and they shouldn't advertise it as fully compatible and it's designed for buddypress?

tw2113 commented 2 years ago

I know I try to with https://github.com/WebDevStudios/BuddyPress-Registration-Options/blob/master/includes/core.php#L147-L190

hellodanevans commented 2 years ago

I asked how can you restrict sending friend requests on a per user bases and they replied this:

You can refer to the following for guidance: https://www.buddyboss.com/resources/reference/hooks/bp_get_friend_accept_request_link/

I'm not 100% that's what we're looking for...