search

WebDevStudios / generator-plugin-wp

Yeoman WordPress Plugin Generator
GNU General Public License v3.0
293 stars 64 forks source link

Let's mirror features between wd_s and the plugin generator #99

Closed gregrickaby closed 7 years ago

gregrickaby commented 7 years ago

Hi everyone!

There's been an incredible push the last week at WDS to get everyone running their code through linters, including: phpcs, eslint, and sass-lint.

Given that both BED and FEDs often bounce between both wd_s and plugin generator during a client build, I'd like to see our linting and build tools mirrored.

During the last #5ftf we linted wd_s...

...which could serve as a baseline here?

Looking forward to discussing further! 👊🏻

binarygary commented 7 years ago

I poked around with this a bit and I'll probably take a swing at the linting to start with as it looks the least disruptive. I'm also pretty certain we don't concat or minify and those would also be easy wins.

As far as the jQuery WDS standard I think the generated .js file is in compliance. If not, lets open it as it's own issue.

The same probably applies to DocBlocks...a good simple issue to fix.

colorful-tones commented 7 years ago

Also integrating .editorconfig would be nice for parity https://github.com/WebDevStudios/wd_s/issues/201

binarygary commented 7 years ago

I think this is at a point where it's ready to go. However, I'd like some frequent wd_s users to give a once over? Please look at https://github.com/WebDevStudios/generator-plugin-wp/pull/106

binarygary commented 7 years ago

I decided to go ahead and merge this. https://github.com/WebDevStudios/generator-plugin-wp/pull/106 There is no overall impact for current users.
Potential undiscovered bugs are all related to the new Gulp functionality.
I think it best to merge this which will allow us to get used to the Gulp workflow and fix problems with it as we go.

binarygary commented 7 years ago

Going to go ahead and close as most recent merge and version bump to 0.17.1 handled quite a few fixes. As problems are discovered please open a new issue for each individual problem.