search

WebDevStudios / oops-wp

A collection of abstract classes, interfaces, and traits to promote object-oriented programming practices in WordPress.
57 stars 9 forks source link

Feature abstract menu registration #31

Closed chrispian closed 4 years ago

chrispian commented 4 years ago

@jmichaelward

Thanks for the great feedback. This definitely made things much simpler and easier to follow. I ran into one thing I'll bring up on the next BEE scrum related to namespacing related to this work.

Tested and seems to work well. Let me know if there are any changes or if I missed anything. Thanks again for reviewing.

jmichaelward commented 4 years ago

Thanks for putting this together, @chrispian. Naturally, I'm caught up on client business after being out of the office for a few days, but I've made note to review this and hope to get back to it later this week.

jmichaelward commented 4 years ago

@chrispian Thanks for making these updates. I pulled this down and made a few minor adjustments to whitespace and the text in the thrown UnexpectedValueException - nothing major, just a few things for consistency with the rest of the library.

I've also updated the PR to go into develop - I only want changes to go into master once a release is ready, which I'm hoping we'll get one out today.

Thanks for the contribution!