search

WebDevStudios / oops-wp

A collection of abstract classes, interfaces, and traits to promote object-oriented programming practices in WordPress.
57 stars 9 forks source link

Update composer files to add PHP 8 support and other minor adjustments. #39

Closed jmichaelward closed 3 years ago

jmichaelward commented 3 years ago

Hey gang!

I've made some extremely minor adjustments in this PR, and was hoping one of you would be able to review and potentially merge and tag this change. The PR contains the following changes:

  1. Updates the composer.json and composer.lock file to include PHP 8 in the set of requirements for the library, making it installable on sites using PHP 8.
  2. Updates my author contact information. WDS maintainers could consider adding their own contact info, or a general author role, to this authors block.
  3. Added a missing return PHP doc to a method in the ShortcodeInterface interface.
  4. Changed the order of the comment typehint due to warnings thrown in PhpStorm.

The most important change in this PR is the first one, but I think they're all relevant. Assuming this looks good, after merge, someone at WDS will need to tag this release, which should automatically make it available via Packagist.org. Please feel free to reach out to me with any questions - I'd be more than happy to help facilitate the process. My contact info is, well, in this PR. 😛

jmichaelward commented 3 years ago

I didn't realize this was from your fork, can you update the changelog on this PR to 1.0.0 and I'll merge & tag?

@jrfoell I missed this notification yesterday. I've updated this. Let me know if you need anything else. Thanks!