WebDevStudios / wd_f

GNU General Public License v2.0

11 stars 1 forks source link

WDSUS-42 - Install ACF Pro as part of the theme. #54

Closed khleomix closed 1 year ago

khleomix commented 1 year ago

Closes WDSUS-42

What type of PR is this? (put an x to all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[x] 🧑‍💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[x] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Link to test

Test locally, run composer install inside the theme

Description

Add ACF Pro plugin into the theme composer file, plugin will be installed when composer install is run. This makes sure that the plugin is installed since the Block WPCLI script is dependent on the plugin.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

N/A

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[x] 📜 README.md
[ ] 📓 Confluence
[ ] 🙅 no documentation needed

Others

[ ] 🦮 Is this issue accessible? (Section 508/WCAG 2.0AA)
[x] 🙌 Does this issue pass all the linting? (PHPCS, ESLint, SassLint)

[optional] Are there any post-deployment tasks we need to perform?

khleomix commented 1 year ago

Closing this because we're going another way.