WebDevStudios / wds-headless-wordpress

This codebase has been moved to a monorepo. Please see the documentation to learn more. 🍻
https://github.com/WebDevStudios/nextjs-wordpress-starter
GNU General Public License v2.0
32 stars 15 forks source link

`composer lint` Attempts Handle Content Outside the Core Functionality #18

Closed tommcfarlin closed 3 years ago

tommcfarlin commented 3 years ago

Problem

composer lint which is a combination of a couple of commands:

  1. composer run compat
  2. composer run lint:php

Attempts to scan more than the standard wds_headless theme directory.

Solution

Introduce additional exclusion patterns into .phpcs.xml.dist to ignore anything that is outside the core purview of the WDS Headless theme.

tommcfarlin commented 3 years ago

After more research, it looks like composer run compat is using the PHPCompatibility standard which will need to be updated to have its own custom ruleset so it scans only our core files.

More information can be found about this here.

tommcfarlin commented 3 years ago

Duplicate of #17