search

WebDevStudios / wp-search-with-algolia

Improve search on your site. Autocomplete is included, along with full control over look, feel and relevance.
https://wordpress.org/plugins/wp-search-with-algolia/
136 stars 53 forks source link

jQuery still getting enqueued with InstantSearch #257

Open tw2113 opened 1 year ago

tw2113 commented 1 year ago

https://wordpress.org/support/topic/dont-load-jquery-2/

jQuery and jQuery Migrate still show up

Screen Shot 2022-11-01 at 12 35 00 PM
tw2113 commented 1 year ago

Turns out this is because we rely on /wp-includes/js/wp-util.js which has its own dependency on jQuery.

This file provides the wp.template() functions that we use to help with rendering some of the autocomplete and instantsearch information.

tw2113 commented 1 year ago

This may be going away as an issue once Autocomplete 1.x gets handled, since templating has changed a lot between versions.

tw2113 commented 1 year ago

This will also be getting able to be forced with InstantSearch 5.x which is removing older legacy templating methods, which we still utilize.

tw2113 commented 1 month ago

While we're moving on from wp-util template usage in the Instantsearch.php file, we're momentarily leaving the libraries included, as we don't want to break users' websites that have customized the older style. They should be granted time to update/upgrade.

Thus leaving this issue open.