[WiP] - Improving the Settings SYNC of the Primary/Replica Indices

WebDevStudios / wp-search-with-algolia

Improve search on your site. Autocomplete is included, along with full control over look, feel and relevance.

https://wordpress.org/plugins/wp-search-with-algolia/

146 stars 55 forks source link

[WiP] - Improving the Settings SYNC of the Primary/Replica Indices #319

Open mskapusuz opened 1 year ago

mskapusuz commented 1 year ago

The PR aims prevents overriding remote Algolia Index Settings.

Key features

Only push a setting if the remote value is null or does not exists.
[to be implemented] Forcefully push a setting ability. If a setting key is defined as should be pushed forcefully override it even though it's exists and not null.
Reduce redundant code in Algolia_Index::get_settings methods

PR description will be updated when the PR is ready for the review.

Closes #317

tw2113 commented 1 year ago

Hi @mskapusuz

This is looking intriguing and also a different method than I was likely originally thinking in my ongoing comments in #317, which I'm not complaining about.

Let us know if you want some early testing of things or at least once you feel it's ready for formal testing, and we can help kick the tires.

mskapusuz commented 1 year ago

Hi @mskapusuz

This is looking intriguing and also a different method than I was likely originally thinking in my ongoing comments in #317, which I'm not complaining about.

Let us know if you want some early testing of things or at least once you feel it's ready for formal testing, and we can help kick the tires.

Hey @tw2113

Great! I will notify you as soon as it is ready for early testing. Thank you!

mskapusuz commented 1 year ago

Hi @mskapusuz

This is looking intriguing and also a different method than I was likely originally thinking in my ongoing comments in #317, which I'm not complaining about.

Let us know if you want some early testing of things or at least once you feel it's ready for formal testing, and we can help kick the tires.

Hey @tw2113

I'm available to work on this again. The remaining things seem to:

An ability to push the settings as forcefully can help structural change needs in the future.
Code style, PHPCS

Do you think the forceful push ability can be helpful? I would appreciate hearing back from you before moving forward.

mskapusuz commented 1 year ago

Hey Daniel, @w3bdesign

I'm Mustafa. As I see, you've approved that. Thanks for your contribution.

tw2113 commented 1 year ago

I don't have answers for the first item, but that'd be the first thing I'd suggest focusing on. I'm not as immediately worried about code style/PHPCS as I would be about functionality.

mskapusuz commented 1 year ago

I don't have answers for the first item, but that'd be the first thing I'd suggest focusing on. I'm not as immediately worried about code style/PHPCS as I would be about functionality.

Thank you! I think that ability helps to be adapted for potential changes on the Algolia side. Therefore, I would like to implement it. I'll let you know when it's done.