Prevent table content from being concatenated

[rodrigo-arias]

This PR prevents the contents of table blocks from being concatenated by making them unsearchable. A space is added after the cell tags so that they remain independent words after applying wp_strip_all_tags.

Before

After

[tw2113]

Hey @rodrigo-arias overall things look good and it makes sense. One question I have is if there's need to cover the closing tags as well: </td> and </th> or if the changes you provide cover those cases enough.

[tw2113]

Didn't mean to switch them. I meant more handling all 4. :)

[rodrigo-arias]

Hey @tw2113 adding a space in the closing tags as well would generate double spaces (end of one cell and opening of the next). However, your comment led me to update the code to replace the closing tags, this has two advantages:

• Avoid concatenation with the Caption.
• Prevents replace from not being applied if, for some strange reason, someone programmatically adds classes to the opening tags (closing tags will never have attributes).

Before

After

[tw2113]

Duly noted on those change reasons.

Overall I approve of this, but we need to figure out a next release plan, so I'm not merging just yet.

[tw2113]

I'm wondering if it'd maybe be better put in this spot: https://github.com/WebDevStudios/wp-search-with-algolia/blob/2.7.1/includes/class-algolia-utils.php#L199-L203

You'd be doing the exact same thing, essentially in the exact same process, except in one method call earlier, and it'd match up better with other similar code.

[rodrigo-arias]

No rush, I'm not actually using the plugin, I noticed it in my fork and wanted to contribute in case it was useful to someone else. Thank you.