WebEferen / flutter_wallet_card

Flutter Wallet Card plugin (iOS & Android)
MIT License
12 stars 23 forks source link

fix run on android #3

Closed nimr77 closed 1 year ago

nimr77 commented 1 year ago

this has a fix for building on android, and updating the plugin

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 808abec4a40f77789df30372d5a88e1bd2e61f6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

WebEferen commented 1 year ago

Thank You @nimr77 for solving that particular issue.

WebEferen commented 1 year ago

As follow-up small task for myself:

nimr77 commented 1 year ago

Thank you, I had to remove the example code just to run the app and test it on Android

WebEferen commented 1 year ago

No worries, had no idea that s1 still might be using the passkit so will bump it and update to match some of new Flutter 3.0 features such as Null safety etc.

nimr77 commented 1 year ago

could you update the package on dart pub

WebEferen commented 1 year ago

Done, sorry for delay but the ci workflow was missing. This week will update it to make it automatic :)