search

WebFreak001 / code-debug

Native debugging for VSCode
The Unlicense
410 stars 115 forks source link

check for configured debugger before start to provide a nicer error message #401

Closed GitMensch closed 9 months ago

GitMensch commented 1 year ago

This is a side issue to #398 (I'd like to provide a similar PR for that).

As I'm currently only "on the browser" I have neither tested that nor run prettier, but I think the current state is enough for a first review.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.35 :warning:

Comparison is base (26d7d9f) 21.30% compared to head (28634f5) 20.95%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #401 +/- ## ========================================== - Coverage 21.30% 20.95% -0.35% ========================================== Files 14 14 Lines 1737 1766 +29 Branches 375 382 +7 ========================================== Hits 370 370 - Misses 1322 1351 +29 Partials 45 45 ``` | [Impacted Files](https://app.codecov.io/gh/WebFreak001/code-debug/pull/401?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/gdb.ts](https://app.codecov.io/gh/WebFreak001/code-debug/pull/401?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2dkYi50cw==) | `0.00% <0.00%> (ø)` | | | [src/lldb.ts](https://app.codecov.io/gh/WebFreak001/code-debug/pull/401?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsZGIudHM=) | `0.00% <0.00%> (ø)` | | | [src/mago.ts](https://app.codecov.io/gh/WebFreak001/code-debug/pull/401?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL21hZ28udHM=) | `0.00% <0.00%> (ø)` | | | [src/mibase.ts](https://app.codecov.io/gh/WebFreak001/code-debug/pull/401?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL21pYmFzZS50cw==) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

GitMensch commented 1 year ago

That change is easy to test, so those should be added before pulling, too.

GitMensch commented 9 months ago

@WebFreak001 Should I rebase - or isn't this likely to get merged?

WebFreak001 commented 9 months ago

feel free to merge your own commits as well, I think error message improvements and such are always very useful