WebFreak001 / dub-upgrade

Run `dub upgrade` trying to repeat on network failure and using package cache on GitHub Actions
1 stars 0 forks source link

this.source.on is not a function #10

Open SingingBush opened 1 month ago

SingingBush commented 1 month ago

On multiple build jobs I'm seeing failures when using dub-upgrade. For some reason it seems to only be an issue for Windows https://github.com/buggins/ddbc/actions/runs/10510047395

There's not much output but as shown in https://github.com/buggins/ddbc/actions/runs/10510047395/job/29215665569 it's due to this.source.on is not a function:

Run WebFreak001/dub-upgrade@v0.1
  with:
    cache: true
    store: false
  env:
    DC: dmd
Received 0 of 66[4](https://github.com/buggins/ddbc/actions/runs/10510047395/job/29215665569#step:6:4)5991 (0.0%), 0.0 MBs/sec
Error: dub upgrade failed: TypeError: this.source.on is not a function
SingingBush commented 1 month ago

I think this is a node version problem, so migrating to node20 will probably be the solution

schveiguy commented 1 month ago

Same problem, but mine is happening on all platforms. Is there a workaround?

https://github.com/mysql-d/mysql-native/actions/runs/10589258590/job/29343082604?pr=283

SingingBush commented 1 month ago

I've simply removed the step that used WebFreak001/dub-upgrade as it wasn't needed (also turned out that I had only set it to run on Windows builds). @schveiguy perhaps it's worth just removing, if there's a need to check the project builds with newer dependencies you could manually have dub upgrade run in a terminal

schveiguy commented 1 month ago

Hm.. I think I just copied the CI from somewhere else, because I think I didn't even check in the dub.selections file. So this is a no-op anyway. I'll just remove permanently.