WebFreak001 / dub-upgrade

Run `dub upgrade` trying to repeat on network failure and using package cache on GitHub Actions
1 stars 0 forks source link

update Node version to 16 #5

Open SingingBush opened 1 year ago

SingingBush commented 1 year ago

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: WebFreak001/dub-upgrade, WebFreak001/dub-upgrade

SingingBush commented 10 months ago

This is still an issue but the message has now changed:

The following actions uses node12 which is deprecated and will be forced to run on node16: WebFreak001/dub-upgrade@v0.1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Worth noting though that actions should now be using node20 as shown in the docs runs for JavaScript actions. This is also what actions/checkout@v4 uses.

I've been using the dub-upgrade action for a few years without issue, if it can run on node20 without any problems perhaps it's worth tagging a v1

WebFreak001 commented 9 months ago

I used to do dub upgrade everywhere, but nowadays I rather bundle the dub.selections.json

This action is missing the possibility to only fetch and cache dependencies, not touching the selections file.

You should probably rather use GitHub's cache action to cache ~/.dub if you want the dependency caching speed-up.