WebGLSamples / WebGL2Samples

Short and easy to understand samples demonstrating WebGL 2 features
Other
1.01k stars 143 forks source link

UBO draw instanced sample #110

Closed trungtle closed 8 years ago

trungtle commented 8 years ago

As noted in #14, this PR contains only one of the 2 samples that Shrek built. This is the draw_instanced_ubo sample to minimally demonstrate ubo.

The other sample involves some lighting and specular calculation, is more of a direct port from Christophe's but it still have some issues so I took it out from this PR.

pjcozzi commented 8 years ago

The other sample involves some lighting and specular calculation, is more of a direct port from Christophe's but it still have some issues so I took it out from this PR.

Did you move this to another branch for now?

trungtle commented 8 years ago

@pjcozzi The other sample is in branch dev-shrek-buffer-uniform still

shrekshao commented 8 years ago

Oh the layout locations i think. Thanks for pointing this out.

On Tuesday, March 15, 2016, Trung Le notifications@github.com wrote:

@pjcozzi https://github.com/pjcozzi The other sample is in branch dev-shrek-buffer-uniform still

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/WebGLSamples/WebGL2Samples/pull/110#issuecomment-196944789

trungtle commented 8 years ago

I updated the layout location