search

WebGLSamples / WebGL2Samples

Short and easy to understand samples demonstrating WebGL 2 features
Other
1.01k stars 143 forks source link

Retest in time for SIGGRAPH #128

Closed pjcozzi closed 8 years ago

pjcozzi commented 8 years ago

@trungtle @shrekshao would it be possible for you guys to retest all the examples on the latest developer browsers before SIGGRAPH and update the table in the README.md

pjcozzi commented 8 years ago

Also, SIGGRAPH is the week after next.

shrekshao commented 8 years ago

Sure. I'll take care of that

trungtle commented 8 years ago

I'll do the same for OSX test! Also, we'll see you guys at SIGGRAPH.

On Thu, Jul 14, 2016 at 8:41 PM, Shuai Shao (Shrek) < notifications@github.com> wrote:

Sure. I'll take care of that

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WebGLSamples/WebGL2Samples/issues/128#issuecomment-232831697, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdsZcpWhrDt6rLc-fyRvCA-Z2-BC5PXks5qVtcxgaJpZM4JM-o- .

pjcozzi commented 8 years ago

Very nice, thanks @shrekshao @trungtle!

kenrussell commented 8 years ago

Note: http://webglsamples.org/WebGL2Samples/#draw_image_space seems to have a bug in the shader. Could you look into this at the same time? Thanks.

The samples are looking good! They all run well on Chrome Canary on my MacBook Pro Retina.

shrekshao commented 8 years ago

No problem. We will take care of that! Thanks.

On Fri, Jul 15, 2016 at 4:53 PM, Ken Russell notifications@github.com wrote:

Note: http://webglsamples.org/WebGL2Samples/#draw_image_space seems to have a bug in the shader. Could you look into this at the same time? Thanks.

The samples are looking good! They all run well on Chrome Canary on my MacBook Pro Retina.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WebGLSamples/WebGL2Samples/issues/128#issuecomment-233067042, or mute the thread https://github.com/notifications/unsubscribe-auth/AEzGrGqG5Ko5WLZw1iqwNMJar31TNy79ks5qV_MwgaJpZM4JM-o- .

trungtle commented 8 years ago

Retested all OSX samples.

I have updated compatibilities accordingly in the chart. On the Chrome side, only etc compression sample doesn't seem to work, error with using gl.compressedTexImage2D with invalid enum. I'll investigate further.

On Fri, Jul 15, 2016 at 4:59 PM, Shuai Shao (Shrek) < notifications@github.com> wrote:

No problem. We will take care of that! Thanks.

On Fri, Jul 15, 2016 at 4:53 PM, Ken Russell notifications@github.com wrote:

Note: http://webglsamples.org/WebGL2Samples/#draw_image_space seems to have a bug in the shader. Could you look into this at the same time? Thanks.

The samples are looking good! They all run well on Chrome Canary on my MacBook Pro Retina.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/WebGLSamples/WebGL2Samples/issues/128#issuecomment-233067042 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AEzGrGqG5Ko5WLZw1iqwNMJar31TNy79ks5qV_MwgaJpZM4JM-o-

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WebGLSamples/WebGL2Samples/issues/128#issuecomment-233068362, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdsZQyVNoOsxIYiW0Hct2eXRT-AZbuwks5qV_SXgaJpZM4JM-o- .

pjcozzi commented 8 years ago

@trungtle thanks for testing promptly.

@kenrussell @toji @zhenyao really impressive work getting your WebGL 2.0 implementation into such good shape!

kenrussell commented 8 years ago

@pjcozzi @trungtle @shrekshao thanks for your excellent work on this samples pack! It will be a valuable resource for developers.

Thanks for retesting. Could you please file a bug about the fbo_rtt_texture_array sample crashing on https://bugs.chromium.org/p/angleproject/issues/list ? Please send me the bug ID once done. Thanks.

The texture_etc2_eac failure on Mac OS X should be fixed soon; the ETC/EAC decompression code was just added on that platform. @vonture @zhenyao

shrekshao commented 8 years ago

Hi Ken

Sure. I think I can do that tomorrow evening.

Thanks for your help and suggestions through out the process. I do feel I learn a lot from working with you. I will continue to keep an eye on this repo for any updates and fixes. (At least I should be able to do a uniform buffer sample making more sense since the driver issue of my machine should be fixed)

Shrek

On Sun, Jul 17, 2016 at 10:11 PM, Ken Russell notifications@github.com wrote:

@pjcozzi https://github.com/pjcozzi @trungtle https://github.com/trungtle @shrekshao https://github.com/shrekshao thanks for your excellent work on this samples pack! It will be a valuable resource for developers.

Thanks for retesting. Could you please file a bug about the fbo_rtt_texture_array sample crashing on https://bugs.chromium.org/p/angleproject/issues/list ? Please send me the bug ID once done. Thanks.

The texture_etc2_eac failure on Mac OS X should be fixed soon; the ETC/EAC decompression code was just added on that platform. @vonture https://github.com/vonture @zhenyao https://github.com/zhenyao

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WebGLSamples/WebGL2Samples/issues/128#issuecomment-233218230, or mute the thread https://github.com/notifications/unsubscribe-auth/AEzGrEbbjb5nqj6wOLtnkRp2fmBDJIwlks5qWuDagaJpZM4JM-o- .

shrekshao commented 8 years ago

@kenrussell Issue 1451 https://bugs.chromium.org/p/angleproject/issues/detail?id=1451

kenrussell commented 8 years ago

Thanks. Commented on the bug and CC'd a couple of others.