vertex format: half float conversion

WebGLSamples / WebGL2Samples

Short and easy to understand samples demonstrating WebGL 2 features

Other

1.01k stars 143 forks source link

vertex format: half float conversion #96

Closed shrekshao closed 8 years ago

shrekshao commented 8 years ago

This is based on the vertex format branch #88
I used a straight-forward (not optimized) method to do the half float transition.
The transition function is now built-in with the sample code.
The correctness needs checking. Although I have gone through several cases including normalized, subnormal, and zero.
I think I can wrap up the code for a utility only after the correctness checking and algorithm optimization. So it might not be done before GDC.

shrekshao commented 8 years ago

Pack up the code to a new js in third-party, use closure.

shrekshao commented 8 years ago

@pjcozzi I've wrapped up the code to a separate .js file and use closure. How are we going to handle this sample? Shall we close the sample for now and reopen it after we do strict unit test for the half float convert tool?

pjcozzi commented 8 years ago

@shrekshao I think it is fine to merge this sample before making a separate standalone utility for half floats. Just keep #91 open.

shrekshao commented 8 years ago

Ready:

change name to HalfFloat; change file name as comment and move the file to samples/
use HalfFloat for texcoord as well
delete color byte buffer

pjcozzi commented 8 years ago

Looks great! We'd still want to do a bit more cleanup to make HalfFloat a standalone library for WebGL 2.0 apps, but we'll save that for #91 and perhaps a future semester.