search

WebGLSamples / WebGLSamples.github.io

WebGL Samples and Examples
https://webglsamples.org
Other
886 stars 269 forks source link

Improve Aquarium MS Edge compatibility #25

Closed Oletus closed 6 years ago

Oletus commented 6 years ago

The regexpes used for shader code filtering need to allow CRLF besides just LF to be compatible with Edge when opening the page through a file: URL or using the server config included in the repository. The issue doesn't appear on webglsamples.org so it may be specific to a certain git configuration but with the patch either style of line endings will work.

greggman commented 6 years ago

Please don't use a file URL. that's a bad practice. use a simple file server. Here a bunch. They take zero to 90 seconds to setup

https://stackoverflow.com/questions/12905426/what-is-a-faster-alternative-to-pythons-http-server-or-simplehttpserver

Oletus commented 6 years ago

This patch is not specific only to file URLs - I get the same issue also when accessing the page through the server from server/ directory. Updated the pull request description to reflect that.

I don't see a big problem with using file URLs either in some situations, but that's another conversation.

Oletus commented 6 years ago

Obsolete now that the regexpes were changed in a different way.