search

WebJamApps / breakpointministries

MIT License
0 stars 0 forks source link

Swap Node-Sass for Dart Sass && Swap to NPM #122

Closed Unesdala closed 3 years ago

JoshuaVSherman commented 3 years ago

i guess they suck and are behind on their images

so use 12 then, sorry for asking you to up to 13

in package use

=16.12.0 <17

thanks

On Wed, Oct 27, 2021 at 1:17 PM Rhayven @.***> wrote:

@.**** commented on this pull request.

In .circleci/config.yml https://github.com/WebJamApps/breakpointministries/pull/122#discussion_r737686165 :

@@ -4,7 +4,7 @@ jobs: environment: CC_TEST_REPORTER_ID: 1c5b2bd21bcb5b2ec6cef1ac6c47761bf5cb0f00b06165874141e1afb2c9e8ef docker:

    • image: circleci/node:stretch
    • image: cimg/node:16.12.0-browsers

Any idea what the code for that is? Highest I could find for 16 was 16.12.0. It goes from that into 17 and trying out 16.13.0 and 16.13.0-browsers just errored out with a no image found.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/WebJamApps/breakpointministries/pull/122#discussion_r737686165, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFY3WCE7WIEBFO6QMYSSZLUJAXZRANCNFSM5F4ULPVA .

-- Josh Sherman https://web-jam.com https://www.linkedin.com/in/joshuavsherman/ 540-494-8035

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit 35861845 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.