WebKit / Speedometer

An open source repository for the Speedometer benchmark
Other
614 stars 73 forks source link

News site - add translation data #272

Closed flashdesignory closed 1 year ago

flashdesignory commented 1 year ago

This pr adds data files for Japanese and Arabic to both the next.js and nuxt version. The data files are made available, but are currently NOT used in the test suites.

To preview locally, runnpm run dev and navigate to these urls:

http://127.0.0.1:7000/resources/newssite/news-next/dist/index.html http://127.0.0.1:7000/resources/newssite/news-next/dist/index.html?lang=jp http://127.0.0.1:7000/resources/newssite/news-next/dist/index.html?lang=ar

http://127.0.0.1:7000/resources/newssite/news-nuxt/dist/index.html http://127.0.0.1:7000/resources/newssite/news-nuxt/dist/index.html?lang=jp http://127.0.0.1:7000/resources/newssite/news-nuxt/dist/index.html?lang=ar

Note: The number of files is higher, since both apps needed to get built with the data files included.

@kara

julienw commented 1 year ago

Looks good to me now!

flashdesignory commented 1 year ago

@rniwa - does this pr work for you?