search

WebKit / Speedometer

An open source repository for the Speedometer benchmark
Other
592 stars 68 forks source link

Update prettier, change print width to 120, and enable dangling commas for functions #371

Open julienw opened 6 months ago

julienw commented 6 months ago

Fixes #370

I didn't regenerate all workloads (yet). Please do not land this just yet, this PR is here so that we can decide about #370.

I made separate commits so that we can easily see the effect of each action:

  1. update Prettier
  2. add dangling commas to functions
  3. change printWidth to 120
rniwa commented 6 months ago

At this point, I'd rather not take a huge PR like this into the repo right before the release even if it should not have any real impact on performance in theory.

rniwa commented 6 months ago

Adding v3.1 label to match the label on https://github.com/WebKit/Speedometer/issues/370

julienw commented 6 months ago

At this point, I'd rather not take a huge PR like this into the repo right before the release even if it should not have any real impact on performance in theory.

fully agreed, this was definitely meant for after the release. Thanks for adding the label.

julienw commented 3 months ago

Loooking good. I guess we can redo the formatting now that we've released?

yeah, I was waiting to see if there was some interest before doing more work :-)

camillobruni commented 3 months ago

I'd definitely prefer some width-limit, especially for the html files.

julienw commented 3 months ago

I rebased and refreshed all affected benchmarks.

On my Linux:

Firefox Before: image

Firefox After: image

Chrome Before: image

Chrome After: image

(I don't have a Mac so I can't try Safari)