I noticed that the github action runs the formatter, but doesn't check that anything was actually reformatted as a result. So it was always successful.
To fix the issue, my strategy is to run a special form of git status whose output won't change over time. If the output is empty, this means that there's no change. Otherwise the action outputs some helpful diagnostics.
I noticed that the github action runs the formatter, but doesn't check that anything was actually reformatted as a result. So it was always successful.
To fix the issue, my strategy is to run a special form of
git statuswhose output won't change over time. If the output is empty, this means that there's no change. Otherwise the action outputs some helpful diagnostics.Here are examples of output: Failing: https://github.com/WebKit/Speedometer/actions/runs/7920439286/job/21623479161?pr=374 Successful: https://github.com/WebKit/Speedometer/actions/runs/7920372392/job/21623262244?pr=374