search

WebKit / Speedometer

An open source repository for the Speedometer benchmark
Other
592 stars 68 forks source link

Fix Hidden dropdown menus #376

Closed issackjohn closed 6 months ago

issackjohn commented 6 months ago

closes #362

actual change is in resources/todomvc/big-dom-generator/src/app.css.

Before:

Screenshot 2024-02-16 at 9 55 40 AM

After:

Screenshot 2024-02-16 at 9 56 18 AM
rniwa commented 6 months ago

What is getting fixed here?

issackjohn commented 6 months ago

This PR fixes #362 which describes how the popover menus are being hidden behind the tree-area in the Complex-DOM shell.

image

This changes make it so that they show up on top.

Screenshot 2024-02-16 at 8 45 34 PM
mattwoodrow commented 6 months ago

It looks like the "show-more" class also has a popover div that isn't affected by these changes.

issackjohn commented 6 months ago

Thanks @mattwoodrow. Will update.

lpardosixtosMs commented 6 months ago

I think this is good to merge, but I'll confirm with Isaack first. I'll merge it tomorrow at the latest.