Make about.html text reflect currently enabled workloads

WebKit / Speedometer

An open source repository for the Speedometer benchmark

Other

592 stars 68 forks source link

Make about.html text reflect currently enabled workloads #381

Closed issackjohn closed 6 months ago

issackjohn commented 6 months ago

closes #380

This PR:

updates the list in about.html such that it reflects the currently enabled workloads.
Adds a missing README.md for Lit complex
Adds a missing README.md for javascript-web-components-complex
capitalizes all readme files for all the workloads

issackjohn commented 6 months ago

@rniwa, should I change the readme in lit to be README.md?

rniwa commented 6 months ago

@rniwa, should I change the readme in lit to be README.md?

What do you mean? Like capitalize it? I don't think we need to do that.

flashdesignory commented 6 months ago

To make it less confusing, can we capitalize all readme files for all the workloads?

rniwa commented 6 months ago

To make it less confusing, can we capitalize all readme files for all the workloads?

I'm fine with that. We need to be at least consistent in capitalization between file names & hyperlinks.

issackjohn commented 6 months ago

To make it less confusing, can we capitalize all readme files for all the workloads?

I'm fine with that. We need to be at least consistent in capitalization between file names & hyperlinks.

Looks like the README files are being treated as newly added files instead? All I did was rename them.

flashdesignory commented 6 months ago

@issackjohn - did you moved the file from [some path]/readme.md to [some path]/README.md? Currently I see both (lowercase and uppercase) in the directories.

issackjohn commented 6 months ago

@issackjohn - did you moved the file from [some path]/readme.md to [some path]/README.md? Currently I see both (lowercase and uppercase) in the directories.

@flashdesignory Oh that's strange. That's not what I did, I renamed the files, but my git wasn't picking up the changes so I ran git config core.ignorecase false. Should I have done the move instead? Are you seeing the duplicates locally or here on the 'Files changed' tab in the PR?

issackjohn commented 6 months ago

I think I should revert the commit.

flashdesignory commented 6 months ago

@issackjohn - usually if you need to change casing, it's easiest to move the files to avoid problems. I'd suggest to revert and rename each readme file.

issackjohn commented 6 months ago

@issackjohn - usually if you need to change casing, it's easiest to move the files to avoid problems. I'd suggest to revert and rename each readme file.

@flashdesignory I tried doing mv [some path]/readme.md [some path]/README.md but it seems like git won't pick up on the change unless i git config core.ignorecase false, but even then, it's still labeling it as a new file like before.

issackjohn commented 6 months ago

Okay, looks like readme.md -> abc.md ->README.md catches the rename properly.

rniwa commented 6 months ago

Could you squash the commits into one?