Closed issackjohn closed 6 months ago
@rniwa, should I change the readme in lit to be README.md?
@rniwa, should I change the readme in lit to be README.md?
What do you mean? Like capitalize it? I don't think we need to do that.
To make it less confusing, can we capitalize all readme
files for all the workloads?
To make it less confusing, can we capitalize all
readme
files for all the workloads?
I'm fine with that. We need to be at least consistent in capitalization between file names & hyperlinks.
To make it less confusing, can we capitalize all
readme
files for all the workloads?I'm fine with that. We need to be at least consistent in capitalization between file names & hyperlinks.
Looks like the README files are being treated as newly added files instead? All I did was rename them.
@issackjohn - did you moved the file from [some path]/readme.md
to [some path]/README.md
?
Currently I see both (lowercase and uppercase) in the directories.
@issackjohn - did you moved the file from
[some path]/readme.md
to[some path]/README.md
? Currently I see both (lowercase and uppercase) in the directories.
@flashdesignory Oh that's strange. That's not what I did, I renamed the files, but my git wasn't picking up the changes so I ran git config core.ignorecase false
. Should I have done the move instead? Are you seeing the duplicates locally or here on the 'Files changed' tab in the PR?
I think I should revert the commit.
@issackjohn - usually if you need to change casing, it's easiest to move the files to avoid problems. I'd suggest to revert and rename each readme file.
@issackjohn - usually if you need to change casing, it's easiest to move the files to avoid problems. I'd suggest to revert and rename each readme file.
@flashdesignory I tried doing mv [some path]/readme.md [some path]/README.md
but it seems like git won't pick up on the change unless i git config core.ignorecase false
, but even then, it's still labeling it as a new file like before.
Okay, looks like readme.md -> abc.md ->README.md catches the rename properly.
Could you squash the commits into one?
closes #380
This PR: