WebKit / Speedometer

An open source repository for the Speedometer benchmark

Other

592 stars 68 forks source link

Fix Cross-platform issue with npm script #397

Closed issackjohn closed 6 months ago

issackjohn commented 6 months ago

closes #396

This change allows the npm test scripts to also run on windows machines.

The PR:

switches the way the browser is defined when running tests. Initially, the browser was determined via environment variables (e.g., BROWSER=chrome node tests/run.mjs). However, this PR alters the approach to use command line arguments instead (e.g., node tests/run.mjs --browser chrome).
The Run tests step in the ci workflow now uses the npm scripts
make npm run format work as well.

YahyaMohamedYahya commented 5 months ago

Thank you