Don't display invalid results

WebKit / Speedometer

An open source repository for the Speedometer benchmark

Other

592 stars 68 forks source link

Don't display invalid results #406

Closed camillobruni closed 1 month ago

camillobruni commented 4 months ago

This partially fixes #399 by not display non-finite scores which are caused by 0-measured suite results.

For non-positive or non-finite scores, the following summary page is displayed. Note that the detailed page is still accessible since you might find some useful information there.
Additionally a console.error is generated for each zero-sum suite

flashdesignory commented 4 months ago

should we display a message to the user, explaining what happened and that the details view might have useful information?

camillobruni commented 4 months ago

Updated version with a better description:

rniwa commented 4 months ago

Rather than "Invalid Score", how about "Error"? Also, we should probably stop right away when we detect an invalid value instead of running 'til completion.

camillobruni commented 4 months ago

camillobruni commented 4 months ago

Updated the code to stop after the first iteration with a broken score (tracking errors across the TestInvoker seems a bit more tricky at the moment).

camillobruni commented 3 months ago

@rniwa could you have another look maybe?

camillobruni commented 3 months ago

@rniwa do you have additional feedback or would be ok with landing with your proposed changes?