search

WebKit / Speedometer

An open source repository for the Speedometer benchmark
Other
592 stars 68 forks source link

Remove obsolete eslint ignore #410

Closed kkuegler closed 1 month ago

kkuegler commented 3 months ago

The offending new Promise(async ...) code was already removed in 19184dc69432fa7e511e13f3318c8c3e1acd28ca but this linting comment remained.

julienw commented 3 months ago

We could use reportUnusedDisableDirectives: true, in our eslint configuration as well as add --report-unused-disable-directives when calling eslint in our CI and package.json. Note it's useful to use both, because the property reportUnusedDisableDirectives only warns (so it doesn't error the test) but shows up in editors, while the command line parameter errors and fails the test.