Closed flashdesignory closed 3 weeks ago
Hey Thorsten, can you remind me when/where we've discussed about introducing localStorage into a workload?
As far as I know, the latest decision about that was https://github.com/WebKit/Speedometer/pull/251#discussion_r1237232511, that is localStorage introduces I/O in the workloads and therefore is another source of noise, so we decided to not include it in workloads.
It's totally possible I forgot about a past discussion too.
@julienw - there was previous concern and we did opt out of using localStorage for our workloads for 3.0.
The reason I think that it's a valid addition:
I'm also happy to include this in an experimental branch, if there's still concern. Although I believe that we are missing out on opportunities to optimize for our users, if we're not taking storage apis in consideration. They ARE widely used, if we optimize for them or not.
Let's maybe incubate this as an experimental workload and see how it behaves on various devices (I have to test this on mobile as well which are known to have slow flash storage).
Maybe we could prime the local storage (aka. a single access in prepare) so we don't necessarily measure the first-time setup costs if they're disproportional to the runtime costs?
changes since last comment:
This pr switches the storage from in-memory to localStorage for todomvc-es5.
Scores snapshot:
@kara