search

WebKit / Speedometer

An open source repository for the Speedometer benchmark
Other
593 stars 70 forks source link

TodoMVC - React - add id to input #428

Open flashdesignory opened 2 weeks ago

flashdesignory commented 2 weeks ago

This adds an id to the toggle all input - see: https://github.com/tastejs/todomvc/pull/2257

@kara

flashdesignory commented 2 weeks ago

looks good to me, but:

* the same issue exists in the workload for react-redux and preact, can you please fix them as well?

* the "complex" versions of these workloads need to be rebuilt as well

Thanks!

Oh thanks for taking a look at the other ones. I'll fix those too and rebuild the complex versions

flashdesignory commented 2 weeks ago

numbers just in case:

React browser before after
chrome 30.57 31.85
firefox 31.47 31.83
safari 31.67 32.20
React-Redux browser before after
chrome 33.04 32.85
firefox 36.23 36.13
safari 36.67 33.83
Preact browser before after
chrome 10.58 10.74
firefox 10.67 11.53
safari 12.20 10.77