search

WebKit / Speedometer

An open source repository for the Speedometer benchmark
Other
593 stars 70 forks source link

Change default port to 8900 #429

Closed mdubet closed 1 week ago

mdubet commented 1 week ago

Port 7000 is occupied by default on macOS. This also makes it simpler how to customize it (use env var instead of hardcoded in the package.json)

https://github.com/WebKit/Speedometer/issues/325

rniwa commented 1 week ago

FWIW, we should wait for approval from other browser vendors.

flashdesignory commented 1 week ago

should we also update the port when running speedometer in dev mode?

https://github.com/WebKit/Speedometer/blob/main/package.json#L18-L19

mdubet commented 1 week ago

should we also update the port when running speedometer in dev mode?

main/package.json#L18-L19

The current patch changes both. (dev and server)