WebKit / Speedometer

An open source repository for the Speedometer benchmark
Other
616 stars 75 forks source link

Runner Cleanup: SuiteRunner & TestRunner classes #452

Closed flashdesignory closed 1 week ago

flashdesignory commented 2 weeks ago
bgrins commented 2 weeks ago

I like the direction here - would like @julienw to review the change if possible.

@flashdesignory to confirm - the big picture idea here is that remote tests will (eventually) consume resources/test-runner.mjs themselves, and it will grow functionality to manage communication back and forth with the suite (postMessage etc)?

flashdesignory commented 2 weeks ago

@flashdesignory to confirm - the big picture idea here is that remote tests will (eventually) consume resources/test-runner.mjs themselves, and it will grow functionality to manage communication back and forth with the suite (postMessage etc)?

remote tests would use the test-runner class, that's correct 😄. postMessage communication will happen on a higher level in the workloads, not on a test-runner level.

julienw commented 1 week ago

FTR looks good to me!