search

WebKitNix / webkitnix

A WebKit2 port based on POSIX and OpenGL/ES
http://nix.openbossa.org
66 stars 24 forks source link

Buildfix for OpenGL ES2 build #1

Closed rgabor-dev closed 11 years ago

rgabor-dev commented 11 years ago

I'm not sure that these changes are correct so I need somebody to review.

jeez commented 11 years ago

@hugopl , we summon you. :)

kalyankondapally commented 11 years ago

Same with GLDefs change. Why do we need to include OpenGLShims for Gles??

rgabor-dev commented 11 years ago

It was necessary because GL_READ_FRAMEBUFFER and GL_READ_FRAMEBUFFER are missing from gl2ext.h and I don't know how to fix it properly. (it is needed at platform/graphics/opengl/GLPlatformSurface.cpp) The other problem was glBlitFramebuffer() and with OpenGLShims.h I could solve this problem, thats why I used it.

kalyankondapally commented 11 years ago

k, there is no support for EXT_framebuffer_blit on GLES2, which defines all the needed attachment points for blitting. Even though we might get it complied, it would cause run time issues. I have some changes pending which should solve this for GraphicsSurface implementations. Would put it for review today eve or so.

kalyankondapally commented 11 years ago

k, there is no support for EXT_framebuffer_blit on GLES2, which defines all the needed attachment points for blitting. Even though we might get it complied, it would cause run time issues. I have some changes pending which should solve this for GraphicsSurface implementations. Would put it for review today eve or so.

hugopl commented 11 years ago

So I think is better to wait for kalyan patches, btw those add_definitions aren't needed, they should already exist in the generated cmakeconfig.h file.

rgabor-dev commented 11 years ago

Thanks Hugo, I see now how it works. I thought that these defines coming from the .cmake files. Anyway I agree with waiting for Kalyan patches and then just the Tools/WebKitTestRunner/nix/PlatformWebViewNix.cpp left to fix.

jeez commented 11 years ago

Do we need to keep this open?

rgabor-dev commented 11 years ago

I think we can close this. I will check later the status of the Opengl ES2 build.