WebKitNix / webkitnix

A WebKit2 port based on POSIX and OpenGL/ES
http://nix.openbossa.org
66 stars 24 forks source link

Nix-MiniBrowser: page layout is broken after window resize in touch mode #33

Closed ebalint closed 11 years ago

ebalint commented 11 years ago

In touch mode, if you resize the window, in most of the cases the webpage's size doesn't adapt to the new window size.

hugopl commented 11 years ago

Do you have some example or steps to reproduce this? I tried here and couldn't reproduce this.

ebalint commented 11 years ago

Steps to reproduce: you open google.com in the MiniBrowser in touch mode. Then you resize the window to full size, and after that you resize it to previous size. The page will be smaller than the window, and there will be a blank space on the left side.

i'm working on this bug, and i've found a fix.

what do you think, is it okay?

patch:

https://gist.github.com/ebalint/4e6ecf189cb658bf3647

ebalint commented 11 years ago

Beside this, i've found another problem with the window resizing / zooming. If you're on a page, and go to another page, then resize the window and go back to previous page, the zooming on the previous page will be incorrect. For this bug I haven't found a solution yet, but i'm working on it.

hugopl commented 11 years ago

Your fix seems right.

I wasn't able to reproduce because the bug happens only when the maxinimize button is clicked, if the window is resized using the window border handlers the bug doesn't occur.

qrwteyrutiyoup commented 11 years ago

Fixed by ca0a13c7.