search

WebMemex / webmemex-extension

📇 Your digital memory extension, as a browser extension
https://webmemex.org
Other
208 stars 45 forks source link

Support deleting visits/pages (fix #21) #102

Closed Treora closed 7 years ago

Treora commented 7 years ago

Clicking the trash bin button now deletes that specific visit. It also deletes the page object the visits refers to; unless there is still another visit referring to it, or to an 'equivalent page': i.e. a page redirecting (possibly indirectly) to the same page through a 'seeInstead' link.

Fixes #21.

blackforestboi commented 7 years ago

I wonder if the use case is rather having one visit or all traces of the page deleted? My gut says more the latter, but it may be an option to have a prompt, where the user is asked if he either wants to delete just the visit or everything about this page?

Treora commented 7 years ago

I decided to take the most obvious approach: clicking the trash button on a visit deletes that visit. Not all visits to that same page object, nor to all pages from the same URL, nor to the same domain. This seems fine for MVP, other options can come later.