Unit tests for activity-logger module

WebMemex / webmemex-extension

📇 Your digital memory extension, as a browser extension

https://webmemex.org

Other

208 stars 45 forks source link

Unit tests for activity-logger module #109

Closed reficul31 closed 6 years ago

reficul31 commented 7 years ago

Refs Initial implementation of the activity logger tests.

reficul31 commented 7 years ago

@Sanjo @Treora Any inputs on the tests?

reficul31 commented 7 years ago

@Sanjo @Treora For now I have left the decision of testing the non exported functions, we could have a discussion in the future to decide the fate of non exported function testing. I have update the PR with the tests asked for the logPageVisit function after the refactoring done by @Treora . Please review and do tell if any more changes in tests are required.

Treora commented 6 years ago

Closing this old PR. As project focus has changed, the logging-all-pages feature is off the roadmap for the foreseeable future. Thanks again for the effort though. :)