WebMemex / webmemex-extension

📇 Your digital memory extension, as a browser extension
https://webmemex.org
Other
208 stars 45 forks source link

Clean up file/folder organisation #112

Closed Treora closed 6 years ago

Treora commented 7 years ago

The organisation of this repo has become a bit messy over time. I intend to move some things around soon, currently thinking about these changes:

poltak commented 7 years ago

(where do we put images?)

Could put them in sub dirs of the main module's dir, like src/overview/img, reflecting the build extension/overview/img and just add entries for them into staticFiles in the gulpfile. Or have another top level dir for static assets mirroring the src/ and extension/ structures, like assets/{overview,options}/{fonts,img}/.

HTML files could be treated as static files in the same way, or could unify them in a shared template and spit them out for their respective build tasks using something like gulp-template.

Treora commented 7 years ago

Thanks still for the input. For now the question about images is solved, since there are no images anymore (using semantic-ui's icons and ditched the background). The question will probably pop up again though.

I started cleaning up in the 'cleanup' branch, checking at least some of the boxes.

Treora commented 7 years ago

Move html files out of extension, into src

This one has been done in 124319d. The other tasks may have to wait a bit; upcoming feature developments may give a better picture of the logical grouping. I suspect the aspects of logging visits and storing pages should be more clearly separated.

Treora commented 6 years ago

Lots of reorganisation done in #135. It could always be better, but it seems good enough to close this.