search

WebMemex / webmemex-extension

📇 Your digital memory extension, as a browser extension
https://webmemex.org
Other
208 stars 45 forks source link

Unit tests for Util Module #116

Closed reficul31 closed 6 years ago

reficul31 commented 7 years ago

Refs There is definitely some room for improvement(least to say). I have tried implementing everything @Sanjo instructed here.

reficul31 commented 7 years ago

@Treora

If it's not too much effort, it would actually be much easier to just create separate PRs for each file you test, so we can merge them one by one as they are ready and keep an easy overview of what's left to be done.

Its no effort at all. Do you want me to close all the un-reviewed pull requests and make individual ones?

Treora commented 7 years ago

Its no effort at all. Do you want me to close all the un-reviewed pull requests and make individual ones?

@reficul31: I was talking just about this PR with tests for things in /src/util/. Others can be considered after that; I try to just tackle one at a time.

reficul31 commented 7 years ago

@Treora @Sanjo Almost done?

Treora commented 6 years ago

Hey @reficul31, sorry about this effort losing momentum; I hardly got around to do anything on this project in the past few weeks. I was also waiting for you to fix a few last things we discussed in the reviews, and I now see you have done most of that, so that is great.

With your summer of code having come to an end, I want to thank you for all the work you have done! I hope you learnt a lot. At least I did. :) Sorry that most things did not get merged in this period; it is simply a lot of code that I should, even after initial reviews, carefully read, test and tweak, while I had other priorities in order to get things working and released. Your contribution is very much appreciated though. I intend to pick up from your branches, go through the code and probably make some last changes myself, and then merge the things that seem ready.

reficul31 commented 6 years ago

I totally understand, it is better to keep the code under review for a longer time that to merge undependable code. I would be there to edit, change and rebase the code whenever a review is posted on the PR. If there is anything more I can do please do leave a comment on the respective PRs, I would be happy to change the code accordingly. PS. The summer of code was a blast. Thanks a lot for all the help and review during the coding period. It really helped me learn a lot.

reficul31 commented 6 years ago

Continued at PR