search

WebMemex / webmemex-extension

📇 Your digital memory extension, as a browser extension
https://webmemex.org
Other
208 stars 45 forks source link

Extension eventually stops working #121

Closed rfrelow closed 6 years ago

rfrelow commented 7 years ago

I'm using Firefox, and have "store every visited webpage" checked. After some time, the extension stops making new snapshots. If I disable and re-enable the extension, it works for a few pages then stops again. If I completely remove and reinstall the extension, it works again for some time (until it breaks).

When it breaks it looks like this, and won't work even for manually capturing pages:

screen shot 2017-07-29 at 1 10 57 am

It feels like it's hitting a limitation of stored pages. Using version 0.2.3.

Treora commented 7 years ago

Thanks for reporting. I would like to investigate, but I have no idea what would be the cause of this. So unless I would end up encountering the same problem myself, I would need to hear more information about the situation. If you're comfortable with browser consoles, you might be able to find relevant error messages in the developer console for the extension's background script (should be possible to open through about:debugging), or perhaps in the developer console of the page itself (F12).

In any case, it would be helpful to know after roughly how many pages the issue occurs. Dozens, hundreds, ...?

rfrelow commented 7 years ago

I'll play around with it more later, but here are the errors I'm getting right now. This doesn't show up when the extension is working:

screen shot 2017-07-29 at 8 36 55 am screen shot 2017-07-29 at 8 39 54 am

Database quota exceeded it seems.

rfrelow commented 7 years ago

This happens roughly after a few hundred pages have been saved. Let me know if there's anything else I can provide that can help!

Treora commented 7 years ago

That indeed looks like you have hit a storage limit. I fear there is not much we can do about that in the current setup, besides telling the user what went wrong (edit: b613ff1 adds an error message to popup).

We could anyhow request the unlimitedStorage permission in the manifest (edit: done in d5dd52f), but Firefox does not currently support this (see MDN).

It could be questioned whether the switch to store every web page is even worth keeping. It does currently not make a great experience, since it stores pages every time they are visited or even reloaded, and it is too modal to my taste (it is invisible and thereby easy to forget about).

Treora commented 6 years ago

Closing this issue. Automatically storing pages is no longer a feature, so presumably storage limits are not hit so easily anymore.