search

WebMemex / webmemex-extension

📇 Your digital memory extension, as a browser extension
https://webmemex.org
Other
208 stars 45 forks source link

GetBrowserInfo() is throwing error in chrome #122

Closed swissums closed 7 years ago

swissums commented 7 years ago

In omnibar.js

The

let browserName
;(async () => {
    const browserInfo = await browser.runtime.getBrowserInfo()
    browserName = browserInfo.name
})()

Throws an Error in chrome as the function browser.runtime.getBrowserInfo() isn't supported. see this link

I don't fully understand why the name is needed?

swissums commented 7 years ago

Sorry this is in the wrong depository... meant to be in the Brainworld WebMememex

Treora commented 7 years ago

This has been fixed since. If this is still a problem in WorldBrain they could cherry-pick commit cf47449 from here.

Feel free to open up issues here if they are not WorldBrain-specific, most WorldBrain code is still the same.

Treora commented 7 years ago

I don't fully understand why the name is needed?

If you still have that question: Firefox does not support markup (<dim>, <url>) that Chrome supports and will just display these tags literally.