search

WebMemex / webmemex-extension

📇 Your digital memory extension, as a browser extension
https://webmemex.org
Other
208 stars 45 forks source link

Filter by bookmarks #39

Closed blackforestboi closed 6 years ago

blackforestboi commented 7 years ago

User story

As a user, I want to filter my results by bookmarks.

Treora commented 7 years ago

Good idea. UI-wise, perhaps we could add a small button to the search query to open up some search choices, including a toggle for this (and soon a time filter and probably other things).

wimpykid26 commented 7 years ago

@Treora @oliversauter in reference to https://github.com/WebMemex/webmemex-extension/issues/29

How do we differentiate if the entry in the model is a bookmark. Is only the nonce used to differentiate between a bookmark and other entries?.

blackforestboi commented 7 years ago

@wimpykid26 We'll discuss about it today.

Rohanhacker commented 7 years ago

can I work on this ?

blackforestboi commented 7 years ago

For now, we have not represented a bookmark as such in the data model, therefore a complete implementation is blocked.

@Treora An important question still to answer: Should we treat a bookmark as a separate object type, as for example visits or for now just as a flag inside the page object (is_bookmark)?

Treora commented 7 years ago

@Treora https://github.com/Treora An important question still to answer: Should we treat a bookmark as a separate object type, as for example visits or for now, just as a flag inside the page object (|is_bookmark|)?

Separate object type.

Treora commented 6 years ago

Closing this issue; the assumption here was that the results would also contain many pages that were automatically stored, which is now off the roadmap. Some form of integration with bookmarks may still be interesting but would have to be reimagined.