search

WebMemex / webmemex-extension

📇 Your digital memory extension, as a browser extension
https://webmemex.org
Other
208 stars 45 forks source link

Fixed issue on History no updating for web apps #59

Closed gastonche closed 7 years ago

gastonche commented 7 years ago

PR pertaining to issue #50. Please do review soon and give me feedback. This is my first PR here so, please do point out any errors I may have made in the process, so i can correct it now and subsequently.

gastonche commented 7 years ago

I have updated the PR. You can check it now

Treora commented 7 years ago

Thanks; I will have a look later and try it out myself.

Treora commented 7 years ago

I tried it out and played around a bit, and see how you came to your solutions. I hope you don't mind I am not going to merge this PR however, as I would rather first revise the activity logger to have it keep some state about the tabs and their recent history, after which a solution like the one you found can be implemented quite elegantly. Thanks for exploring and reporting this!

gastonche commented 7 years ago

Okay no qualms.